Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use openssl_is_fips instead of hasFipsCrypto #28507

Closed
wants to merge 4 commits into from
Closed

test: use openssl_is_fips instead of hasFipsCrypto #28507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0d943f4
test: use openssl_is_fips instead of hasFipsCrypto
danbev Jul 2, 2019
f1e2dc6
squash!: add comment about using config property
danbev Jul 3, 2019
1d6935e
test: update hasFipsCrypto in test/common/README
danbev Jul 5, 2019
7a1fac4
squash!: test: update hasFipsCrypto in test/common/README
danbev Jul 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion test/common/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,12 @@ Indicates whether OpenSSL is available.
### hasFipsCrypto
* [<boolean>]

Indicates `hasCrypto` and `crypto` with fips.
Indicates that Node.js has been linked with a FIPS compatible OpenSSL library,
and that FIPS as been enabled using `--enable-fips`.

To only detect if the OpenSSL library is FIPS compatible, regardless if it has
been enabled or not, then `process.config.variables.openssl_is_fips` can be
used to determine that situation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very important challenge with using process.config is that there are userland modules that overwrite it's value. That is, it cannot be relied upon in every case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the documentation for our test utility functions. Interference from userland modules shouldn't be an issue.


### hasIntl
* [<boolean>]
Expand Down
9 changes: 8 additions & 1 deletion test/parallel/test-process-env-allowed-flags-are-documented.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,14 @@ const conditionalOpts = [
return ['--openssl-config', '--tls-cipher-list', '--use-bundled-ca',
'--use-openssl-ca' ].includes(opt);
} },
{ include: common.hasFipsCrypto,
{
// We are using openssl_is_fips from the configuration because it could be
// the case that OpenSSL is FIPS compatible but fips has not been enabled
// (starting node with --enable-fips). If we use common.hasFipsCrypto
// that would only tells us if fips has been enabled, but in this case we
// want to check options which will be available regardless of whether fips
// is enabled at runtime or not.
include: process.config.variables.openssl_is_fips,
filter: (opt) => opt.includes('-fips') },
{ include: common.hasIntl,
filter: (opt) => opt === '--icu-data-dir' },
Expand Down