doc: remove URLs from zlib and tls docs #28580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsemozhetbyt
reviewed
Jul 6, 2019
addaleax
approved these changes
Jul 6, 2019
Trott
approved these changes
Jul 6, 2019
|
Nits addressed. Green lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3749/ |
cjihrig
added
the
author ready
BridgeAR
approved these changes
Jul 8, 2019
This commit replaces two long URLs in the TLS documentation with linked text. PR-URL: nodejs#28580 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit removes two URLs from the zlib documentation. One of the URLs is already linked to in the previous sentence, so it is removed completely. The other is changed to more human friendly link text. PR-URL: nodejs#28580 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in 3091115...4742e4d. |
targos
pushed a commit
that referenced
this pull request
Jul 20, 2019
This commit replaces two long URLs in the TLS documentation with linked text. PR-URL: #28580 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Jul 20, 2019
This commit removes two URLs from the zlib documentation. One of the URLs is already linked to in the previous sentence, so it is removed completely. The other is changed to more human friendly link text. PR-URL: #28580 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes several absolute URLs from the zlib and tls docs in favor of more reader friendly link text.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes