Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: simplify DEP0062 logic #28589

Merged
merged 1 commit into from
Jul 9, 2019
Merged

src: simplify DEP0062 logic #28589

merged 1 commit into from
Jul 9, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jul 7, 2019

This commit simplifies the DEP0062 error logic. Instead of looking for certain combinations of flags, just show an error for any usage of --debug or --debug-brk.

Fixes: #28588

It's also worth noting that DEP0062 was moved to End-of-Life, meaning that all of this logic can be removed. However, it might be worth leaving it around to print the deprecation message since --debug is a much more logical name than --inspect.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jul 7, 2019
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 8, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/24329/

EDIT(cjihrig): CI was yellow.

@cjihrig cjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 8, 2019
This commit simplifies the DEP0062 error logic. Instead of
looking for certain combinations of flags, just show an error
for any usage of --debug or --debug-brk.

PR-URL: nodejs#28589
Fixes: nodejs#28588
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@cjihrig cjihrig merged commit b851469 into nodejs:master Jul 9, 2019
@cjihrig cjihrig deleted the debug branch July 9, 2019 20:59
targos pushed a commit that referenced this pull request Jul 20, 2019
This commit simplifies the DEP0062 error logic. Instead of
looking for certain combinations of flags, just show an error
for any usage of --debug or --debug-brk.

PR-URL: #28589
Fixes: #28588
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node --inspect-brk --debug prints incorrect error message
5 participants