Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: edit stream module introduction #28595

Merged
merged 1 commit into from
Jul 12, 2019
Merged

doc: edit stream module introduction #28595

merged 1 commit into from
Jul 12, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 8, 2019

Edit the stream module introduction for concision and simplicity.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Jul 8, 2019
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 8, 2019
@Trott

This comment has been minimized.

Sign in to view
@Trott
Copy link
Member Author

Trott commented Jul 8, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3752/

@Trott
doc: edit stream module introduction
86f8f4f 
Edit the stream module introduction for concision and simplicity.

PR-URL: nodejs#28595
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jul 12, 2019 •
edited
Loading

Landed in 86f8f4f.

@Trott Trott merged commit 86f8f4f into nodejs:master Jul 12, 2019
@Trott Trott deleted the update-stream-intro branch July 12, 2019 05:59
targos pushed a commit that referenced this pull request Jul 20, 2019
@Trott @targos
doc: edit stream module introduction
0380a55 
Edit the stream module introduction for concision and simplicity.

PR-URL: #28595
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Jul 23, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @lpinca @cjihrig @BridgeAR @trivikr @ZYSzys @nodejs-github-bot