Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: cherry-pick ARM64 Windows changes to node-gyp #28604

Closed
wants to merge 2 commits into from

Commits on Jul 11, 2019

  1. deps: cherry-pick 721dc7d from node-gyp upstream

    This change cherry-picks a small set of node-gyp v5.0.0 changes needed
    to enable Node.js ARM64 Windows builds.
    
    Original commit message:
      Add ARM64 to MSBuild /Platform logic
    
      PR-URL: nodejs/node-gyp#1655
      Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
      Reviewed-By: João Reis <reis@janeasystems.com>
    
    Refs: nodejs/node-gyp@721dc7d
    PR-URL: nodejs#28604
    jkunkee authored and joaocgreis committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    dfd204c View commit details
    Browse the repository at this point in the history
  2. deps: cherry-pick 91744bf from node-gyp upstream

    This change cherry-picks a small set of node-gyp v5.0.0 changes needed
    to enable Node.js ARM64 Windows builds.
    
    Original commit message:
      gyp: add support for Windows on Arm
    
      Cherry-pick of refack/GYP3#33, supersedes
      nodejs/node-gyp#1678 until GYP3 is merged.
    
      `npm test` passes
    
      Change-Id: I2b1e1e03e378b4812d34afa527087793864d1576
    
      PR-URL: nodejs/node-gyp#1739
      Reviewed-By: Refael Ackermann <refack@gmail.com>
      Reviewed-By: João Reis <reis@janeasystems.com>
    
    Refs: nodejs/node-gyp@91744bf
    PR-URL: nodejs#28604
    jkunkee authored and joaocgreis committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    c51ec2b View commit details
    Browse the repository at this point in the history