Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readline: simplify isFullWidthCodePoint() #28640

Merged
merged 1 commit into from
Jul 13, 2019
Merged

Commits on Jul 13, 2019

  1. readline: simplify isFullWidthCodePoint()

    The non-ICU-based isFullWidthCodePoint() can be simplified to
    a single `return` statement. This commit removes the extra
    branching logic.
    
    PR-URL: nodejs#28640
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    cjihrig committed Jul 13, 2019
    Configuration menu
    Copy the full SHA
    a130545 View commit details
    Browse the repository at this point in the history