-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stream: eos premature close #28720
stream: eos premature close #28720
Conversation
I'm unsure how to make tests that actually trigger this... but the semantics I think are more correct like this |
554b8e0
to
291d05c
Compare
This actually fixes a bug ( |
@benjamingr who's a good ping on this one? |
I don't mind reviewing it - can you explain the tradeoffs in the new behavior vs. the existing one? |
@benjamincburns |
@nodejs/streams |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a green citgm run
Marking it as semver-major as it changes behavior. |
What is the bug this is fixing? What’s the goal of this change? |
|
afd02b1
to
1ee52d4
Compare
@ronag just to elaborate on Matteo's comment regarding semverness - changes to the order of the events streams (or in general node APIs) fire are pretty substantial changes with possible big implications on the ecosystem so generally they're all semver-major (means they'll be released in the next major release - in this case 13) |
@benjamingr no problem, makes perfect sense |
1ee52d4
to
77ff0d3
Compare
updated test |
merged into #28748 |
For writable premature close is
close
beforefinish
, i.e. it should look forfinished
instead ofended
.Would be better with afinishEmitted
but we don't have that.For readable we should be checking
endEmitted
(which we do first but not later).Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes