Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: skip test-ci doc targets if no crypto #28747

Closed
wants to merge 2 commits into from
Closed

build: skip test-ci doc targets if no crypto #28747

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff462e9
build: skip test-ci doc targets if no crypto
rvagg Jul 18, 2019
4c0da8d
fixup! build: skip test-ci doc targets if no crypto
rvagg Jul 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,11 @@ test-all-suites: | clear-stalled test-build bench-addons-build doc-only ## Run a

CI_NATIVE_SUITES ?= addons js-native-api node-api
CI_JS_SUITES ?= default
CI_DOC := doctool
ifeq ($(node_use_openssl), false)
CI_DOC := doctool
else
CI_DOC =
endif

.PHONY: test-ci-native
# Build and test addons without building anything else
Expand Down Expand Up @@ -700,7 +704,11 @@ tools/doc/node_modules: tools/doc/package.json
.PHONY: doc-only
doc-only: tools/doc/node_modules \
$(apidoc_dirs) $(apiassets) ## Builds the docs with the local or the global Node.js binary.
@$(MAKE) out/doc/api/all.html out/doc/api/all.json
@if [ "$(shell $(node_use_openssl))" != "true" ]; then \
echo "Skipping doc-only (no crypto)"; \
else \
$(MAKE) out/doc/api/all.html out/doc/api/all.json; \
fi

.PHONY: doc
doc: $(NODE_EXE) doc-only
Expand Down