-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: jenkins-iojs.nodesource.com -> ci.nodejs.org, iojs.org/download -> nodejs.org/download #2886
Conversation
lgtm |
LGTM |
@@ -11,11 +11,11 @@ Release authorization is given by the node.js TSC. Once authorized, an individua | |||
|
|||
There are three relevant Jenkins jobs that should be used for a release flow: | |||
|
|||
**a.** **Test runs:** **[iojs+any-pr+multi](https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/)** is used for a final full-test run to ensure that the current *HEAD* is stable. | |||
**a.** **Test runs:** **[iojs+any-pr+multi](https://ci.nodejs.org/job/iojs+any-pr+multi/)** is used for a final full-test run to ensure that the current *HEAD* is stable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we use this job anymore. Probably you can fix this as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be https://ci.nodejs.org/job/node-test-pull-request/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed & rebased over master
, here and in one other place below.
I assume iojs+release
is still used?
@rvagg Are all the jobs right? We can fix it now itself |
The only job in doc/releases.md that have |
|
The Jenkins URL has changed from https://jenkins-iojs.nodesource.com to https://ci.nodejs.org. The former address now redirects to the latter. Some jobs has also changed names.
@silverwind No problem. :) Rebased.
|
The Jenkins URL has changed from https://jenkins-iojs.nodesource.com to https://ci.nodejs.org. The former address now redirects to the latter. Some jobs has also changed names. PR-URL: #2886 Reviewed-By: Rod Vagg <r@va.gg> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Thanks, landed in 02448c6. |
The Jenkins URL has changed from https://jenkins-iojs.nodesource.com to https://ci.nodejs.org. The former address now redirects to the latter. Some jobs has also changed names. PR-URL: #2886 Reviewed-By: Rod Vagg <r@va.gg> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Roman Reiss <me@silverwind.io>
The Jenkins URL has changed from https://jenkins-iojs.nodesource.com
to https://ci.nodejs.org. The former address now redirects to the
latter.
The new download location is https://nodejs.org/download/release/;
the configure script was still referring to
https://iojs.org/download/release/.
(there are separate commits for these changes)