Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add feature TextEncoder.prototype.encodeInto #28860

Closed
wants to merge 3 commits into from
Closed

add feature TextEncoder.prototype.encodeInto #28860

wants to merge 3 commits into from

Conversation

AtticusYang
Copy link

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • [x ] documentation is changed or added
  • [x ] commit message follows commit guidelines

AtticusYang and others added 3 commits July 25, 2019 23:01
encoding: add encodeInto to TextEncoder
454d581
encoding: add encodeInto to TextEncoder
092af43 
Add TextEncoder.prototype.encodeInto.

Refs: nodejs#26904
@AtticusYang
fix MessageChannel is not defined in encodeInto.any.js
db8ad9a 
wpt runner import MessageChannel, fix MessageChannel is not defined in encodeInto.any.js.

Fixes: nodejs#28851
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. labels Jul 26, 2019
@mscdex mscdex mentioned this pull request Jul 26, 2019
Closed
4 tasks
@addaleax addaleax added the duplicate Issues and PRs that are duplicates of other issues or PRs. label Jul 26, 2019
@addaleax
Copy link
Member

I’m closing this as a duplicate of #28862 because that one already has some review context – thanks @mscdex for pointing that out.

@addaleax addaleax closed this Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. duplicate Issues and PRs that are duplicates of other issues or PRs. encoding Issues and PRs related to the TextEncoder and TextDecoder APIs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AtticusYang @addaleax @nodejs-github-bot