-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Include "exports" resolver specification #28899
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit about the non-object edge case. Other LGTM.
@jkrems I believe I've adjusted it to the implementation now, thanks. |
Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3817/ (scheduled--Jenkins is going down but presumably the CI job will kick off when it's back up) |
PR-URL: nodejs#28899 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Landed in 8492acf |
PR-URL: #28899 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This amends the ES module resolver specification in the documentation to include the behaviour of the "exports" feature as implemented and merged in #28568.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes