Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: documented default statusCode #28982

Closed
wants to merge 1 commit into from
Closed

doc: documented default statusCode #28982

wants to merge 1 commit into from

Conversation

nfearnley
Copy link
Contributor

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Aug 5, 2019
@Trott
Copy link
Member

Trott commented Aug 8, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3826/

@Trott
Copy link
Member

Trott commented Aug 8, 2019

Landed in 71c28a4

@Trott Trott closed this Aug 8, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Aug 8, 2019
@nfearnley @Trott
doc: documented default statusCode
71c28a4 
PR-URL: nodejs#28982
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Aug 8, 2019

Thanks for the contribution! 🎉

targos pushed a commit that referenced this pull request Aug 19, 2019
@nfearnley @targos
doc: documented default statusCode
7b7b8f2 
PR-URL: #28982
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Aug 19, 2019
Merged
This was referenced Aug 20, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nfearnley @Trott @jasnell @addaleax @cjihrig @trivikr @nodejs-github-bot