stream: improve read() performance more #28989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
stream
ronag
reviewed
Aug 6, 2019
| if (nb === buf.length) | ||
| ret.set(buf, ret.length - n); | ||
| else | ||
| ret.set(new Uint8Array(buf.buffer, buf.byteOffset, nb), ret.length - n); |
There was a problem hiding this comment.
yes, just confused as two how it can be faster. Some V8 thingy?
There was a problem hiding this comment.
yes. v8 can optimize the stuff it provides, but our buffer copy is basically a black box to it, since its written in c++. we could probably optimize our copy impl to use typedarray's set if there are no source offsets passed.
There was a problem hiding this comment.
wouldn't it better to apply this there then?
targos
approved these changes
Aug 6, 2019
addaleax
approved these changes
Aug 6, 2019
trivikr
approved these changes
Aug 6, 2019
jasnell
approved these changes
Aug 7, 2019
lpinca
approved these changes
Aug 7, 2019
|
Doesn't #29066 supersede this PR? |
|
@ronag Not really, |
PR-URL: nodejs#28989 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
mscdex
force-pushed
the
streams-readable-perf2
branch
from
1744bd1 to
53e467d
Compare
targos
pushed a commit
that referenced
this pull request
Aug 19, 2019
PR-URL: #28989 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Aug 20, 2019
lpinca
referenced
this pull request
in websockets/ws
Jun 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Results:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes