Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: remove duplicate check #29022

Closed
wants to merge 1 commit into from
Closed

http: remove duplicate check #29022

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Aug 6, 2019 •
edited
Loading

socketOnDrain performs the exact same check and doesn't return anything.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Aug 6, 2019
addaleax
addaleax approved these changes Aug 6, 2019
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fwiw, the checks are not identical when state.outgoingData === socket.writableHighWaterMark. I think that should be okay here, though.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24891/

@ronag ronag force-pushed the http-remove-noop branch from e8900ec to 9300b4b Compare August 9, 2019 16:02
@Trott
Copy link
Member

Trott commented Aug 9, 2019

@nodejs/streams @nodejs/http

@Trott Trott added the review wanted PRs that need reviews. label Aug 9, 2019
mcollina
mcollina approved these changes Aug 9, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24933/

@Trott
Copy link
Member

Trott commented Aug 11, 2019

Landed in 7635b7c

@Trott Trott closed this Aug 11, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Aug 11, 2019
@ronag @Trott
http: remove duplicate check
7635b7c 
`socketOnDrain()` performs the exact same check and doesn't return
anything.

PR-URL: nodejs#29022
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Aug 19, 2019
@ronag @targos
http: remove duplicate check
13a4979 
`socketOnDrain()` performs the exact same check and doesn't return
anything.

PR-URL: #29022
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Aug 19, 2019
Merged
This was referenced Aug 20, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. review wanted PRs that need reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ronag @nodejs-github-bot @Trott @mcollina @addaleax @trivikr