Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert.deepEqual: fix bug with faked boxed primitives #29029

Closed
wants to merge 3 commits into from
Closed

assert.deepEqual: fix bug with faked boxed primitives #29029

wants to merge 3 commits into from

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Aug 7, 2019

I discovered this bug while perusing the code, to try to bring the npm deep-equal package into sync with node's.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
    • note: the related tests have passed; i didn't run the full suite
  • tests and/or benchmarks are included
  • documentation is changed or added (n/a)
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Aug 7, 2019
@Trott
Copy link
Member

Trott commented Aug 7, 2019

@nodejs/assert

@ljharb ljharb force-pushed the deep_equal_boxed_primitive branch 2 times, most recently from b30d71d to 2737496 Compare August 7, 2019 03:17
@ljharb ljharb mentioned this pull request Aug 7, 2019
Merged
@ljharb ljharb force-pushed the deep_equal_boxed_primitive branch from 2737496 to d90707a Compare August 7, 2019 05:55
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24886/

@Trott
Copy link
Member

Trott commented Aug 7, 2019

CITGM master: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1934/
CITGM this PR: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1936/ (queued, will 404 until a worker is available)

@Trott
Copy link
Member

Trott commented Aug 7, 2019

Not semver-major, but since assert.deepEqual() can get weird, running CITGM anyway....

If interested in making deepEqual() less weird, check out #28011.

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 8, 2019
@devsnek
Copy link
Member

devsnek commented Aug 9, 2019

Landed in 885c644...8fdd634

@devsnek devsnek closed this Aug 9, 2019
@devsnek devsnek removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 9, 2019
devsnek pushed a commit that referenced this pull request Aug 9, 2019
@ljharb @devsnek
test: assert: add failing deepEqual test for faked boxed primitives
e079f6c 
PR-URL: #29029
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
devsnek pushed a commit that referenced this pull request Aug 9, 2019
@ljharb @devsnek
util: assert: fix deepEqual comparing fake-boxed to real boxed primitive
6c3af76 
PR-URL: #29029
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
devsnek pushed a commit that referenced this pull request Aug 9, 2019
@ljharb @devsnek
util: isEqualBoxedPrimitive: ensure both values are actual boxed Symbols
8fdd634 
... before trying to valueOf them

PR-URL: #29029
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@ljharb ljharb deleted the deep_equal_boxed_primitive branch August 9, 2019 15:36
This was referenced Jan 20, 2021
Open
Open
Open
Open
Open
Open
This was referenced Sep 5, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Closed
@kissofire kissofire mentioned this pull request Jan 1, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Jan 1, 2024
Open
@137717unity 137717unity mentioned this pull request Jan 2, 2024
Open
@molllyn1 molllyn1 mentioned this pull request Jan 2, 2024
Open
@wedataintelligence wedataintelligence mentioned this pull request Jan 2, 2024
Open
@ron-a20 ron-a20 mentioned this pull request Jan 2, 2024
Open
@molllyn1 molllyn1 mentioned this pull request Mar 15, 2024
Open
@ron-a20 ron-a20 mentioned this pull request Mar 15, 2024
Open
@kissofire kissofire mentioned this pull request Mar 15, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Mar 15, 2024
Open
@137717unity 137717unity mentioned this pull request Mar 16, 2024
Open
@wedataintelligence wedataintelligence mentioned this pull request Mar 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

@devsnek devsnek devsnek approved these changes

@joyeecheung joyeecheung Awaiting requested review from joyeecheung

@BridgeAR BridgeAR Awaiting requested review from BridgeAR

Assignees
No one assigned
Labels
util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ljharb @Trott @nodejs-github-bot @devsnek @jasnell @addaleax @targos @trivikr