net, child_process, and buffer doc patches #2903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
createServer() can create socket of types other than TCP.
mscdex
added
buffer
| @@ -366,7 +366,8 @@ callback or returning an EventEmitter). | |||
| * `env` {Object} Environment key-value pairs | |||
| * `stdio` {Array|String} Child's stdio configuration. (See | |||
| [below](#child_process_options_stdio)) | |||
| * `detached` {Boolean} The child will be a process group leader. (See | |||
| * `detached` {Boolean} Prepare child to run independently of it's parent | |||
|
Fixed those two things, otherwise LGTY? |
|
Yea, LGTM with one question. None of the |
|
They do not, the docs here describe the existing behaviour. #2908 depends on this because |
sam-github
added a commit
that referenced
this pull request
Sep 16, 2015
PR-URL: #2903 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
sam-github
added a commit
that referenced
this pull request
Sep 16, 2015
PR-URL: #2903 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
sam-github
added a commit
that referenced
this pull request
Sep 16, 2015
createServer() can create socket of types other than TCP. PR-URL: #2903 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
sam-github
added a commit
that referenced
this pull request
Sep 16, 2015
PR-URL: #2903 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
sam-github
added a commit
that referenced
this pull request
Sep 16, 2015
PR-URL: #2903 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
sam-github
added a commit
that referenced
this pull request
Sep 16, 2015
createServer() can create socket of types other than TCP. PR-URL: #2903 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some minor errors and omissions in docs