Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gyp: cherrypick input.py from node-gyp #29130

Closed
wants to merge 1 commit into from
Closed

gyp: cherrypick input.py from node-gyp #29130

wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Aug 15, 2019

Cherrypick the Python 3 compatibility fixes from the node-gyp repo.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. labels Aug 15, 2019
@cclauss cclauss added the python PRs and issues that require attention from people who are familiar with Python. label Aug 15, 2019
@cclauss cclauss requested a review from sam-github August 15, 2019 00:41
@cclauss cclauss closed this Aug 15, 2019
@cclauss cclauss deleted the py3_input.py branch August 15, 2019 00:50
@sam-github
Copy link
Contributor

@cclauss did you mean to delete the branch?

@cclauss cclauss mentioned this pull request Aug 15, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-github sam-github Awaiting requested review from sam-github

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. python PRs and issues that require attention from people who are familiar with Python. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cclauss @sam-github @nodejs-github-bot