-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix example single-test command #29171
doc: fix example single-test command #29171
Conversation
Changes example command to refer to the correct test directory: `./test/parallel/` instead of `./parallel/`
Some history: Originally the test runner specified tests to run by the name of the test suite (e.g. I'll defer to others as to whether the example should be changed (both the original and the change made in this PR will be accepted by the test runner). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because there's no explanation that you can leave off the test/
(and, for that matter, the .js
), it's probably best to just use the full path like this. I would prefer if the commit message is amended when we land this to say "improve" (or something similar) rather than "fix" as this isn't actually broken, IMO.
Should we also document that |
IMO, neither. |
A little more detail: No need to deprecate. End users never use/see this tool. It's for us. No need to document that you can leave off |
Changes example command to refer to the full test directory: `./test/parallel/` instead of `./parallel/` PR-URL: #29171 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Landed in 287c3ab. Thanks for the contribution! 🎉 |
Changes example command to refer to the full test directory: `./test/parallel/` instead of `./parallel/` PR-URL: #29171 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Changes example command to refer to the correct test directory:
./test/parallel/
instead of./parallel/
Checklist