Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker: fix crash when SharedArrayBuffer outlives creating thread #29190

Closed
wants to merge 1 commit into from
Closed

worker: fix crash when SharedArrayBuffer outlives creating thread #29190

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Keep a reference to the ArrayBuffer::Allocator alive for at least
as long as a SharedArrayBuffer allocated by it lives.

The tests are taken 1:1 from #28788.

Refs: #28788
Fixes: #28777
Fixes: #28773

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@addaleax
worker: fix crash when SharedArrayBuffer outlives creating thread
4d2821f 
Keep a reference to the `ArrayBuffer::Allocator` alive for at least
as long as a `SharedArrayBuffer` allocated by it lives.

Refs: nodejs#28788
Fixes: nodejs#28777
Fixes: nodejs#28773
@addaleax addaleax added the worker Issues and PRs related to Worker support. label Aug 17, 2019
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Aug 17, 2019
@addaleax addaleax mentioned this pull request Aug 17, 2019
Closed
3 tasks
@addaleax addaleax removed the lib / src Issues and PRs related to general changes in the lib or src directory. label Aug 17, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25058/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 19, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25110/

@addaleax
Copy link
Member Author

Landed in 119c4cc

@addaleax addaleax closed this Aug 19, 2019
addaleax added a commit that referenced this pull request Aug 19, 2019
@addaleax
worker: fix crash when SharedArrayBuffer outlives creating thread
119c4cc 
Keep a reference to the `ArrayBuffer::Allocator` alive for at least
as long as a `SharedArrayBuffer` allocated by it lives.

Refs: #28788
Fixes: #28777
Fixes: #28773

PR-URL: #29190
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@addaleax addaleax deleted the worker-sharedarraybuffer-childthread-2 branch August 19, 2019 23:00
targos pushed a commit that referenced this pull request Aug 20, 2019
@addaleax @targos
worker: fix crash when SharedArrayBuffer outlives creating thread
d4e397a 
Keep a reference to the `ArrayBuffer::Allocator` alive for at least
as long as a `SharedArrayBuffer` allocated by it lives.

Refs: #28788
Fixes: #28777
Fixes: #28773

PR-URL: #29190
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request Aug 20, 2019
Merged
This was referenced Aug 20, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

segfault when using SharedArrayBuffer from an unrefed worker thread Access Violation
4 participants
@addaleax @nodejs-github-bot @jasnell @cjihrig