-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: try GitHub Actions CI for running tests #29193
Conversation
Something cancelled the build, I don't know what. |
Seem like when one branch fails, GitHub CI fails the others. |
@cclauss I found there is an option to prevent cancelling the matrix if one job fails: |
Nice! I also found and added continue-on-error at the job level which is analogous to Travis CI's allow_failures. Nice collaboration among Team Switzerland... |
Can someone with Travis CI admin rights please rerun Travis CI - Pull Request? |
There's a Re-Run button but it's not working for me. If all else fails, one thing you can do to get a re-run is force-push to the branch after a basically-no-op rebase. |
409f5d0
to
49c4437
Compare
@cclauss Is this an experiment for now or are you hoping to land this? If the latter, let's ping for some reviews. (And if it should be closed, obviously let's do that.) |
I would be interested to replace Travis CI with GitHub Actions-based CI however GitHub Actions remains in Beta until November. We can close this PR now and create a new one once GitHub Actions goes GA. Thanks to @targos for the investigation. |
Co-Authored-By: Ruben Bridgewater <ruben@bridgewater.de>
run: | | ||
make lint | ||
- name: make test | ||
continue-on-error: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that Node.js should build with Python 3 is continue-on-error
desired?
Since #29474 involved test, I think maybe we can drop this PR ? |
This needs a rebase. |
No longer needed sonce #29474 involved similar tests |
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes