buffer: correct concat() error message #29198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Aug 19, 2019
jasnell
approved these changes
Aug 19, 2019
lpinca
approved these changes
Aug 19, 2019
BridgeAR
approved these changes
Aug 20, 2019
trivikr
reviewed
Aug 20, 2019
| @@ -525,7 +525,7 @@ Buffer.concat = function concat(list, length) { | |||
| // TODO(BridgeAR): This should not be of type ERR_INVALID_ARG_TYPE. | |||
| // Instead, find the proper error code for this. | |||
| throw new ERR_INVALID_ARG_TYPE( | |||
| `list[${i}]`, ['Array', 'Buffer', 'Uint8Array'], list[i]); | |||
| `list[${i}]`, ['Buffer', 'Uint8Array'], list[i]); | |||
There was a problem hiding this comment.
Suggested change
| `list[${i}]`, ['Buffer', 'Uint8Array'], list[i]); | |
| `list[${i}]`, ['Buffer', 'Uint8Array'], buf); |
Trott
pushed a commit
that referenced
this pull request
Aug 22, 2019
PR-URL: #29198 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in 775048d |
BridgeAR
pushed a commit
that referenced
this pull request
Sep 3, 2019
PR-URL: #29198 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes