lib,src,doc: remove usage of events.EventEmitter #2921
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `events` module already exports `EventEmitter` constructor function So, we don't have to use `events.EventEmitter` to access it. Refer: nodejs#2896
thefourtheye
added
doc
| @@ -117,7 +117,7 @@ function onServerResponseClose() { | |||
| // array. That is, in the example below, b still gets called even though | |||
| // it's been removed by a: | |||
| // | |||
| // var obj = new events.EventEmitter; | |||
| // var obj = new events(); | |||
There was a problem hiding this comment.
maybe var obj = new EventEmitter();?
There was a problem hiding this comment.
@evanlucas I updated this. Thanks :-)
The `events` module already exports `EventEmitter` constructor function So, we don't have to use `events.EventEmitter` to access it. Refer: nodejs#2896
thefourtheye
force-pushed
the
events-eventemitter-usage
branch
2 times, most recently
from
742a9ad to
705ff31
Compare
|
Removing the test changes, after a lengthy discussion with @brendanashworth ;-) |
thefourtheye
changed the title
|
LGTM |
1 similar comment
|
LGTM |
Closed
stojanovic
added a commit
to stojanovic/koa
that referenced
this pull request
Oct 24, 2015
The 'events' module already exports 'EventEmitter' constructor function - nodejs/node#2921
This was referenced Nov 11, 2015
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
eventsmodule already exportsEventEmitterconstructor functionSo, we don't have to use
events.EventEmitterto access it.Refer: #2896
cc @silverwind @evanlucas