Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update Http2ServerRequest extends Readable #29253

Closed
wants to merge 1 commit into from
Closed

doc: update Http2ServerRequest extends Readable #29253

wants to merge 1 commit into from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Aug 21, 2019

This PR also removes the redundant statement explained by "extends stream.Readable"

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Aug 21, 2019
@trivikr
Copy link
Member Author

trivikr commented Aug 21, 2019

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3842/

@trivikr
Copy link
Member Author

trivikr commented Aug 21, 2019

CI-Lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3844/

@trivikr trivikr changed the title doc: Http2ServerRequest extends stream.Readable doc: update Http2ServerRequest extends Readable Aug 21, 2019
@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 22, 2019
@trivikr trivikr self-assigned this Aug 22, 2019
@trivikr
Copy link
Member Author

trivikr commented Aug 22, 2019

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3849/

@Trott
Copy link
Member

Trott commented Aug 23, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3851/

Merge commit might mess it up. I'll rebase and re-run if so.

@Trott
Copy link
Member

Trott commented Aug 23, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3852/

Trott pushed a commit that referenced this pull request Aug 23, 2019
@trivikr @Trott
doc: indicate that Http2ServerRequest extends Readable
31c3fc0 
PR-URL: #29253
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
Copy link
Member

Trott commented Aug 23, 2019

Landed in 31c3fc0

@Trott Trott closed this Aug 23, 2019
@trivikr trivikr deleted the extends-stream-Readable branch August 23, 2019 20:53
BridgeAR pushed a commit that referenced this pull request Sep 3, 2019
@trivikr @BridgeAR
doc: indicate that Http2ServerRequest extends Readable
1d649e3 
PR-URL: #29253
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@BridgeAR BridgeAR mentioned this pull request Sep 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees

@trivikr trivikr

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@trivikr @Trott @jasnell @addaleax @lpinca @nodejs-github-bot