Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

child_process: remove use of stream private state #29358

Closed
wants to merge 2 commits into from
Closed

child_process: remove use of stream private state #29358

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bccdfe
stream: cleanup use of inner state
ckarande Aug 26, 2019
66b792b
child_process: format code changes
ckarande Aug 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/internal/child_process.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,8 +298,7 @@ function flushStdio(subprocess) {
// which data can be read from a stream, e.g. being consumed on the
// native layer directly as a StreamBase.
if (!stream || !stream.readable ||
stream._readableState.readableListening ||
stream[kIsUsedAsStdio]) {
stream[kIsUsedAsStdio]) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
stream[kIsUsedAsStdio]) {
stream[kIsUsedAsStdio]) {

Copy link
Contributor

@mscdex mscdex Aug 28, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, it should be able to fit on one line now:

    if (!stream || !stream.readable || stream[kIsUsedAsStdio]) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mscdex for the suggestion. Updated the PR accordingly.

continue;
}
stream.resume();
Expand Down