Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: hard code doctool in test-doc target #29375

Closed
wants to merge 1 commit into from

Commits on Aug 30, 2019

  1. build: hard code doctool in test-doc target

    This commit removes the usage of the CI_DOC variable in the test-doc
    recipe and specifies the doctool argument to tools/test.py explicitly.
    
    The motivation for this is that the build is taking longer time and
    this is mostly due to tests being run twice as the CI_DOC
    variable will be empty in most cases (when not using --without-ssl).
    
    This change was introduced with/after Commit
    9039af8 ("build: skip test-ci doc
    targets if no crypto") and while I though it might make sense to change
    the setting of CI_DOC I not sure about the implications that might have
    to our CI environment. It currently looks like this:
    
    ifeq ($(node_use_openssl), false)
            CI_DOC := doctool
    else
            CI_DOC =
    endif
    
    Which is setting CI_DOC to doctool if there is no crypto support which
    not available. But perhaps this should be be the other way around,
    changing the order or updating condition to be true.
    danbev committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    7df4915 View commit details
    Browse the repository at this point in the history