stream: don't deadlock on aborted stream #29376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all streams (e.g. http.ClientRequest) will always emit 'close' after 'aborted'.
|
ping @mcollina |
jasnell
approved these changes
Aug 30, 2019
lpinca
approved these changes
Aug 30, 2019
|
Landed in 897587c |
mcollina
pushed a commit
that referenced
this pull request
Sep 2, 2019
Not all streams (e.g. http.ClientRequest) will always emit 'close' after 'aborted'. PR-URL: #29376 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Sep 3, 2019
Not all streams (e.g. http.ClientRequest) will always emit 'close' after 'aborted'. PR-URL: #29376 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 4, 2019
Not all streams (e.g. http.ClientRequest) will always emit 'close' after 'aborted'. PR-URL: #29376 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all streams (e.g. http.ClientRequest) will always emit
'close'after'aborted'.Noticed this while fixing some stuff in fastify. I think the root issue will be fixed by #27984. But I still think it's a good idea to have this fix/workaround in the npm stream-readable package for older node versions.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes