-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: remove experimental Python 3 tests #29413
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests do not help us to get closer to Python 3 compatibility and they take up valuable time yet they always fail.
nodejs-github-bot
added
the
build
Issues and PRs related to build files or the CI.
label
Sep 3, 2019
targos
approved these changes
Sep 3, 2019
danbev
approved these changes
Sep 3, 2019
Could we fast track this? Please give a 👍 if you agree or please remove the |
devnexen
approved these changes
Sep 3, 2019
BethGriggs
approved these changes
Sep 3, 2019
danbev
pushed a commit
that referenced
this pull request
Sep 3, 2019
These tests do not help us to get closer to Python 3 compatibility and they take up valuable time yet they always fail. PR-URL: #29413 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Landed in eb2deee. |
cclauss
added
the
python
PRs and issues that require attention from people who are familiar with Python.
label
Sep 3, 2019
targos
pushed a commit
that referenced
this pull request
Sep 20, 2019
These tests do not help us to get closer to Python 3 compatibility and they take up valuable time yet they always fail. PR-URL: #29413 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Merged
This was referenced Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build
Issues and PRs related to build files or the CI.
fast-track
PRs that do not need to wait for 48 hours to land.
python
PRs and issues that require attention from people who are familiar with Python.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests do not help us to get closer to Python 3 compatibility and they take up valuable time yet they always fail.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes