Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: test Python 3.7 on Travis CI #29451

Closed
wants to merge 2 commits into from
Closed

build: test Python 3.7 on Travis CI #29451

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ff431b
build: use python3 to build and test on Travis
cclauss Sep 5, 2019
77fb266
fixup: remove EXPERIMENTAL_NODE_GYP_PYTHON3="yes"
cclauss Oct 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,11 @@ language: cpp
# To experiment with Python 3, comment out Python 2.7 and uncomment one of the Python 3 versions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, with this change, Python 2.7 is already commented out, so this comment needs to be updated?

sam-github marked this conversation as resolved.
Show resolved Hide resolved
env:
global:
- PYTHON_VERSION="2.7.15"
# - PYTHON_VERSION="2.7.15"
# - PYTHON_VERSION="3.6.7"
# - PYTHON_VERSION="3.7.1"
- PYTHON_VERSION="3.7.1"
sam-github marked this conversation as resolved.
Show resolved Hide resolved
- PYTHON=python3
- EXPERIMENTAL_NODE_GYP_PYTHON3="yes"
sam-github marked this conversation as resolved.
Show resolved Hide resolved
jobs:
include:
- stage: "Compile"
Expand Down