Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add comment to .travis.yml on how to test Py3 #29473

Closed
wants to merge 1 commit into from
Closed

build: add comment to .travis.yml on how to test Py3 #29473

wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 6, 2019

Checklist

This PR attempts to fulfill the original intention of #29451

It adds documentation to .travis.yml so that contributors
know how to test Python 3 on Travis CI.

This PR makes no attempt to ensure that those tests pass.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@cclauss cclauss requested a review from sam-github September 6, 2019 11:17
@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Sep 6, 2019
@cclauss cclauss added the python PRs and issues that require attention from people who are familiar with Python. label Sep 6, 2019
This was referenced Sep 6, 2019
Closed
Closed
@sam-github sam-github added fast-track PRs that do not need to wait for 48 hours to land. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Sep 6, 2019
@sam-github
Copy link
Contributor

I think #29451 is more useful, because just turning py3 on doesn't get anyone very far. We know it doesn't work, and we know there are a number of workarounds that need to be pulled in for known problems, and that has to happen before we can discover what new and unknown problems still lurk.

If anyone finds this useful, though, I certainly have no objections, but the comment has to be extended, because I've found that its also necessary to set EXPERIMENTAL_NODE_GYP_PYTHON3 in order to make node-gyp.js find and use python3, cf. #29246 (comment), so changing the version passed to pyenv to 3.7.1, as described here, is not (yet) sufficient to cause the built/test process to actually use py3.

@cclauss
Copy link
Contributor Author

cclauss commented Sep 6, 2019

This PR makes no attempt to ensure that those tests pass.

@cclauss
Copy link
Contributor Author

cclauss commented Sep 9, 2019

Is something blocking us from landing this one?

@sam-github
Copy link
Contributor

Landed in 6723169

@sam-github sam-github closed this Sep 9, 2019
sam-github pushed a commit that referenced this pull request Sep 9, 2019
@cclauss @sam-github
build: add comment to .travis.yml on how to test Py3
6723169 
PR-URL: #29473
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@cclauss cclauss deleted the explain-Travis-test-Py36-or-Py37 branch September 9, 2019 21:36
targos pushed a commit that referenced this pull request Sep 20, 2019
@cclauss @targos
build: add comment to .travis.yml on how to test Py3
b0aef81 
PR-URL: #29473
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
@cclauss @BridgeAR
build: add comment to .travis.yml on how to test Py3
c1695c6 
PR-URL: #29473
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Sep 25, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@sam-github sam-github sam-github approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. python PRs and issues that require attention from people who are familiar with Python.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cclauss @sam-github @lpinca @nodejs-github-bot