Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: indenting child list items for remark-lint #29488

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/api/modules.md
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@ By doing this, Node.js achieves a few things:
- It keeps top-level variables (defined with `var`, `const` or `let`) scoped to
the module rather than the global object.
- It helps to provide some global-looking variables that are actually specific
to the module, such as:
to the module, such as:
- The `module` and `exports` objects that the implementor can use to export
values from the module.
- The convenience variables `__filename` and `__dirname`, containing the
Expand Down
6 changes: 3 additions & 3 deletions doc/api/n-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -3974,13 +3974,13 @@ Returns `napi_ok` if the API succeeded.
N-API offers a way to "wrap" C++ classes and instances so that the class
constructor and methods can be called from JavaScript.

1. The [`napi_define_class`][] API defines a JavaScript class with constructor,
1. The [`napi_define_class`][] API defines a JavaScript class with constructor,
static properties and methods, and instance properties and methods that
correspond to the C++ class.
2. When JavaScript code invokes the constructor, the constructor callback
2. When JavaScript code invokes the constructor, the constructor callback
uses [`napi_wrap`][] to wrap a new C++ instance in a JavaScript object,
then returns the wrapper object.
3. When JavaScript code invokes a method or property accessor on the class,
3. When JavaScript code invokes a method or property accessor on the class,
the corresponding `napi_callback` C++ function is invoked. For an instance
callback, [`napi_unwrap`][] obtains the C++ instance that is the target of
the call.
Expand Down
1 change: 1 addition & 0 deletions doc/changelogs/CHANGELOG_ARCHIVE.md
Original file line number Diff line number Diff line change
Expand Up @@ -3438,6 +3438,7 @@ https://github.com/nodejs/node/commit/726865af7bbafe58435986f4a193ff11c84e4bfe
- Move node.dns into module "dns"
- Move node.fs into module "posix"
- process is no longer the global object. GLOBAL is.

For more information on the API changes see:
http://thread.gmane.org/gmane.comp.lang.javascript.nodejs/6
http://thread.gmane.org/gmane.comp.lang.javascript.nodejs/14
Expand Down
2 changes: 1 addition & 1 deletion doc/changelogs/CHANGELOG_V5.md
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ https://github.com/nodejs/node/pull/5655
* **v8**: backport fb4ccae from v8 upstream (Vladimir Krivosheev) #4231
- breakout events from v8 to offer better support for external debuggers
* **zlib**: add support for concatenated members (Kári Tristan Helgason)
https://github.com/nodejs/node/pull/5120
https://github.com/nodejs/node/pull/5120
* Previously, if multiple members were in the same archive, only the first would be read. The others are no longer thrown away.

### Commits
Expand Down
18 changes: 9 additions & 9 deletions doc/changelogs/CHANGELOG_V7.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,17 +57,17 @@ for details on patched vulnerabilities.
* **build**:
- Disable V8 snapshots - The hashseed embedded in the snapshot is
currently the same for all runs of the binary. This opens node up to
collision attacks which could result in a Denial of Service. We have
temporarily disabled snapshots until a more robust solution is found
(Ali Ijaz Sheikh)
collision attacks which could result in a Denial of Service. We have
temporarily disabled snapshots until a more robust solution is found
(Ali Ijaz Sheikh)
* **deps**:
- CVE-2017-1000381 - The c-ares function ares_parse_naptr_reply(),
which is used for parsing NAPTR responses, could be triggered to
read memory outside of the given input buffer if the passed in DNS
response packet was crafted in a particular way. This patch checks that
there is enough data for the required elements of an NAPTR record (2
int16, 3 bytes for string lengths) before processing a record. (David
Drysdale)
read memory outside of the given input buffer if the passed in DNS
response packet was crafted in a particular way. This patch checks that
there is enough data for the required elements of an NAPTR record (2
int16, 3 bytes for string lengths) before processing a record. (David
Drysdale)

### Commits

Expand Down Expand Up @@ -1552,7 +1552,7 @@ Thank you to @italoacasas for preparing the majority of this release.
* **buffer**:
- Reverted the runtime deprecation of calling `Buffer()` without `new`. (Anna Henningsen) [#9529](https://github.com/nodejs/node/pull/9529)
- Fixed `buffer.transcode()` for single-byte character
encodings to `UCS2`. (Anna Henningsen) [#9838](https://github.com/nodejs/node/pull/9838)
encodings to `UCS2`. (Anna Henningsen) [#9838](https://github.com/nodejs/node/pull/9838)
* **promise**: `--trace-warnings` now produces useful stacktraces for Promise warnings. (Anna Henningsen) [#9525](https://github.com/nodejs/node/pull/9525)
* **repl**: Fixed a bug preventing correct parsing of generator functions. (Teddy Katz) [#9852](https://github.com/nodejs/node/pull/9852)
* **V8**: Fixed a significant `instanceof` performance regression. (Franziska Hinkelmann) [#9730](https://github.com/nodejs/node/pull/9730)
Expand Down
4 changes: 2 additions & 2 deletions doc/guides/contributing/pull-requests.md
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,8 @@ A good commit message should describe what changed and why.
3. Wrap all other lines at 72 columns (except for long URLs).

4. If your patch fixes an open issue, you can add a reference to it at the end
of the log. Use the `Fixes:` prefix and the full issue URL. For other references
use `Refs:`.
of the log. Use the `Fixes:` prefix and the full issue URL. For other
references use `Refs:`.

Examples:
- `Fixes: https://github.com/nodejs/node/issues/1337`
Expand Down