Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix require call for spawn() in code example #29621

Closed
wants to merge 1 commit into from
Closed

doc: fix require call for spawn() in code example #29621

wants to merge 1 commit into from

Conversation

marian-r
Copy link
Contributor

Checklist

@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Sep 19, 2019
@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 21, 2019
@trivikr
Copy link
Member

trivikr commented Sep 21, 2019

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3918/

@Trott
Copy link
Member

Trott commented Sep 22, 2019

Landed in b82ffd9

@Trott Trott closed this Sep 22, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Sep 22, 2019
@marian-r @Trott
doc: fix require call for spawn() in code example
b82ffd9 
PR-URL: nodejs#29621
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Sep 23, 2019
@marian-r @targos
doc: fix require call for spawn() in code example
34e0623 
PR-URL: #29621
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Sep 24, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
@marian-r @BridgeAR
doc: fix require call for spawn() in code example
84b353c 
PR-URL: #29621
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Sep 25, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@devnexen devnexen devnexen approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marian-r @trivikr @Trott @lpinca @devnexen @nodejs-github-bot