Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: optimize the altsvc Max bytes limit, define and use constants #29673

Closed
wants to merge 1 commit into from
Closed

http2: optimize the altsvc Max bytes limit, define and use constants #29673

wants to merge 1 commit into from

Conversation

rickyes
Copy link
Contributor

@rickyes rickyes commented Sep 23, 2019

Altsvc Max bytes extracted constant, can better maintain this limit value

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the http2 Issues or PRs related to the http2 subsystem. label Sep 23, 2019
BridgeAR
BridgeAR approved these changes Sep 23, 2019
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickyes if you like, you could also fix the commit message to fully adhere to our guidelines (the first character after "http: " should be lower cased) with git commit --amend and git push --force-with-lease.

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 23, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25657/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25658/

@rickyes rickyes force-pushed the http2-altsvc-max-bytes branch from 870f274 to 3224a1e Compare September 24, 2019 01:15
@rickyes
Copy link
Contributor Author

rickyes commented Sep 24, 2019

LGTM

@rickyes if you like, you could also fix the commit message to fully adhere to our guidelines (the first character after "http: " should be lower cased) with git commit --amend and git push --force-with-lease.

@BridgeAR Thanks for reminding! Has been changed

@rickyes rickyes changed the title http2: Optimize the altsvc Max bytes limit, define and use constants http2: optimize the altsvc Max bytes limit, define and use constants Sep 24, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25659/

@rickyes
Copy link
Contributor Author

rickyes commented Sep 25, 2019

It's ready

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25700/

@Trott
Copy link
Member

Trott commented Sep 26, 2019

Landed in 322e1e1

@Trott Trott closed this Sep 26, 2019
Trott pushed a commit that referenced this pull request Sep 26, 2019
@rickyes @Trott
http2: optimize the altsvc Max bytes limit, define and use constants
322e1e1 
PR-URL: #29673
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@rickyes rickyes deleted the http2-altsvc-max-bytes branch September 26, 2019 05:33
targos pushed a commit that referenced this pull request Oct 1, 2019
@rickyes @targos
http2: optimize the altsvc Max bytes limit, define and use constants
a04fc86 
PR-URL: #29673
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Oct 1, 2019
Merged
@beevelop beevelop mentioned this pull request Oct 1, 2019
Closed
@trivikr trivikr mentioned this pull request Oct 24, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@JungMinu JungMinu JungMinu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.