Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker: fix process._fatalException return type #29706

Closed
wants to merge 1 commit into from
Closed

worker: fix process._fatalException return type #29706

wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

This makes sure process._fatalException() returns a boolean when
run inside of a worker.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR
worker: fix process._fatalException return type
7981351 
This makes sure `process._fatalException()` returns a boolean when
run inside of a worker.
@BridgeAR BridgeAR requested a review from addaleax September 25, 2019 15:34
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25705/

@BridgeAR BridgeAR added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. worker Issues and PRs related to Worker support. labels Sep 25, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25708/

@Trott
Copy link
Member

Trott commented Sep 27, 2019

Landed in aea9a0f

@Trott Trott closed this Sep 27, 2019
Trott pushed a commit that referenced this pull request Sep 27, 2019
@BridgeAR @Trott
worker: fix process._fatalException return type
aea9a0f 
This makes sure `process._fatalException()` returns a boolean when
run inside of a worker.

PR-URL: #29706
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
targos pushed a commit that referenced this pull request Oct 1, 2019
@BridgeAR @targos
worker: fix process._fatalException return type
ef033d0 
This makes sure `process._fatalException()` returns a boolean when
run inside of a worker.

PR-URL: #29706
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
@targos targos mentioned this pull request Oct 1, 2019
Merged
@beevelop beevelop mentioned this pull request Oct 1, 2019
Closed
@BridgeAR BridgeAR deleted the fix-fatal-exception-return-type branch January 20, 2020 12:05
@kissofire kissofire mentioned this pull request Feb 25, 2021
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Feb 25, 2021
Open
@ron-a20 ron-a20 mentioned this pull request Feb 26, 2021
Open
@sitedata sitedata mentioned this pull request Feb 26, 2021
Open
@meghasfdc meghasfdc mentioned this pull request Feb 26, 2021
Open
@137717unity 137717unity mentioned this pull request Feb 26, 2021
Open
@Rednickle Rednickle mentioned this pull request Feb 26, 2021
Open
This was referenced May 5, 2021
Open
Closed
Closed
Open
Open
@snyk-bot snyk-bot mentioned this pull request May 26, 2021
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Oct 30, 2022
Open
@137717unity 137717unity mentioned this pull request Oct 30, 2022
Open
@molllyn1 molllyn1 mentioned this pull request Oct 30, 2022
Open
@kissofire kissofire mentioned this pull request Oct 30, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 30, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 31, 2022
Open
@ron-a20 ron-a20 mentioned this pull request Oct 31, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 31, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Nov 10, 2022
Open
@kissofire kissofire mentioned this pull request Dec 6, 2023
Open
@137717unity 137717unity mentioned this pull request Dec 6, 2023
Open
@ron-a20 ron-a20 mentioned this pull request Dec 6, 2023
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Dec 6, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Dec 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JungMinu JungMinu JungMinu approved these changes

@devnexen devnexen devnexen approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@BridgeAR @nodejs-github-bot @Trott @jasnell @addaleax @lpinca @devnexen @JungMinu