Revert "stream: make finished call the callback if the stream is closed" #29717

mcollina · 2019-09-26T09:25:40Z

Fixes #29699.

This reverts commit b03845b.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

mcollina · 2019-09-26T09:26:15Z

cc @ronag

mcollina · 2019-09-26T09:28:09Z

@BethGriggs this would need to be pulled in v13 and/or I would remove b03845b from there asap anyway.

nodejs-github-bot · 2019-09-26T09:28:52Z

CI: https://ci.nodejs.org/job/node-test-pull-request/25714/

mcollina · 2019-09-26T09:29:02Z

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2012/

ronag · 2019-09-26T10:10:15Z

I'm a big -1 on this.

Instead of reverting the whole thing, please at least let me make a PR that addresses the specific behavioural change referenced in #29699.

Including:

Documentation for the behaviour.
A big note in the code.
Added test for expected compat.
Workaround for relevant places (if any) in core that uses finished ~~e.g. async iterators~~.

I can have this done by the end of the day.

Also, I would ask us to continue the discussion in #29699 for finding a long term sustainable strategy for this and similar issues. This indirectly impacts pending work and PR's I have that could end up in a similar situation.

With this I would be -0.

benjamingr

I would prefer it if we picked the original one out before the release.

jasnell · 2019-09-26T17:55:00Z

So long as the changes do not go out in a release and @ronag and @mafintosh can collaborate on a revised acceptable solution, then I think we can afford to hold off reverting this immediately. I think we should time box that however, and the change should definitely be pulled out of the 13.0.0 working branch for now while the fix is being worked on.

ronag · 2019-09-26T18:55:52Z

I believe I have found an elegant solution which fixes #29699 and possibly make everyone happy (fingers crossed). #29724

Trott · 2019-10-01T04:01:15Z

@mcollina Unfortunately, there's a merge conflict to be resolved.

@jasnell Do you have a proposal for what should be the time-box deadline? I suppose if @BethGriggs has an opinion, that's probably the opinion we should pay the most attention to.

BethGriggs · 2019-10-01T11:03:21Z

I'd prefer not picking the commit out of the v13.x branch and release - it has already gone into the first RC, and would need to be forced out of a protected branch.

I can pull in this PR or #29724 into the v13.x release once either of those has landed (subject to no TSC objections as per https://github.com/nodejs/node/blob/master/doc/releases.md#release-branch). My plan is to update the v13.x-proposal each Tuesday up until 15th October - after which I'd like to avoid pulling any additional commits into the release.

mcollina · 2019-10-01T12:50:05Z

Then I think we should land this asap and then reapply the PR with the fix if we can land it in time.

jasnell · 2019-10-01T15:31:01Z

I'm happy with whichever approach @BethGriggs and @mcollina are

Trott · 2019-10-01T18:06:15Z

Am I correct that the two options are either rebase this and land it soon, or we can land #29724? (And in either event, the fix needs to get into the 13.x release.) If we know which one we're going with, we can add it to the 13.x milestone.

mcollina · 2019-10-09T17:23:28Z

Given that we are running out of time, I propose we land this as soon as possible (tomorrow) as a precaution. That commit should not reach v13 as-is and we should likely do a an RC release without it.

mafintosh · 2019-10-09T17:33:35Z

Yes, I'm +1 on reverting at this stage as well. This is all super tricky stuff and we need to understand the changes better before trying to land a fix.

Trott · 2019-10-09T17:48:08Z

Given that we are running out of time, I propose we land this as soon as possible (tomorrow) as a precaution. That commit should not reach v13 as-is and we should likely do a an RC release without it.

Yes, I'm +1 on reverting at this stage as well. This is all super tricky stuff and we need to understand the changes better before trying to land a fix.

Based on this, I've added it to the 13.x milestone.

@mcollina This needs a rebase.

Trott

Rubber-stamp LGTM if CI passes and CITGM doesn't show anything surprising and alarming.

Trott · 2019-10-09T17:49:12Z

@nodejs/tsc This is labeled semver-major so will need a second TSC review.

ronag · 2019-10-09T17:51:09Z

Also needs to revert ce62e96 to avoid the conflict.

This reverts commit ce62e96.

This reverts commit b03845b.

nodejs-github-bot · 2019-10-09T18:16:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/25930/ ✔️

Trott · 2019-10-09T22:15:15Z

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2043/

This time, without a typo in the ref so it might actually run the tests.

mcollina · 2019-10-10T08:32:29Z

CITGM seems ok to me, landing.

This reverts commit ce62e96. PR-URL: #29717 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

This reverts commit b03845b. PR-URL: #29717 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

mcollina · 2019-10-10T08:34:59Z

Landed in 7682874...9f873b3

mcollina · 2019-10-10T08:35:21Z

@BethGriggs would you mind adding this to v13?

BethGriggs · 2019-10-10T10:12:22Z

@mcollina I've pulled it into #29504 and I'm currently building rc-2

mcollina added the abandoned label Sep 26, 2019

mcollina requested review from sam-github, mafintosh, jasnell, addaleax, lpinca and a team September 26, 2019 09:25

mcollina added semver-major PRs that contain breaking changes and should be released in the next major version. stream Issues and PRs related to the stream subsystem. and removed abandoned labels Sep 26, 2019

mcollina force-pushed the revert-eos-change branch from 529a573 to 5bbda7e Compare September 26, 2019 09:58

benjamingr approved these changes Sep 26, 2019

View reviewed changes

mafintosh approved these changes Oct 9, 2019

View reviewed changes

Trott added this to the 13.0.0 milestone Oct 9, 2019

Trott approved these changes Oct 9, 2019

View reviewed changes

mcollina added 2 commits October 9, 2019 19:52

Revert "stream: remove ambiguous code"

7fc6286

This reverts commit ce62e96.

Revert "stream: make finished call the callback if the stream is closed"

fe76c85

This reverts commit b03845b.

mcollina force-pushed the revert-eos-change branch from 5bbda7e to fe76c85 Compare October 9, 2019 18:15

ronag mentioned this pull request Oct 9, 2019

stream: remove ambiguous code #29664

Closed

3 tasks

This comment has been minimized.

Sign in to view

BethGriggs approved these changes Oct 9, 2019

View reviewed changes

mcollina closed this Oct 10, 2019

ronag mentioned this pull request Oct 10, 2019

[x] stream: eof & pipeline compat #29724

Closed

4 tasks

MylesBorins added the dont-land-on-v12.x label Jan 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revert "stream: make finished call the callback if the stream is closed" #29717

Revert "stream: make finished call the callback if the stream is closed" #29717

mcollina commented Sep 26, 2019

mcollina commented Sep 26, 2019

mcollina commented Sep 26, 2019

nodejs-github-bot commented Sep 26, 2019

mcollina commented Sep 26, 2019

ronag commented Sep 26, 2019 •

edited

Loading

benjamingr left a comment

jasnell commented Sep 26, 2019

ronag commented Sep 26, 2019 •

edited

Loading

Trott commented Oct 1, 2019

BethGriggs commented Oct 1, 2019

mcollina commented Oct 1, 2019

jasnell commented Oct 1, 2019

Trott commented Oct 1, 2019

mcollina commented Oct 9, 2019

mafintosh commented Oct 9, 2019

Trott commented Oct 9, 2019

Trott left a comment

Trott commented Oct 9, 2019

ronag commented Oct 9, 2019

nodejs-github-bot commented Oct 9, 2019 •

edited by Trott

Loading

This comment has been minimized.

Trott commented Oct 9, 2019 •

edited

Loading

mcollina commented Oct 10, 2019

mcollina commented Oct 10, 2019

mcollina commented Oct 10, 2019

BethGriggs commented Oct 10, 2019

Revert "stream: make finished call the callback if the stream is closed" #29717

Revert "stream: make finished call the callback if the stream is closed" #29717

Conversation

mcollina commented Sep 26, 2019

Checklist

mcollina commented Sep 26, 2019

mcollina commented Sep 26, 2019

nodejs-github-bot commented Sep 26, 2019

mcollina commented Sep 26, 2019

ronag commented Sep 26, 2019 • edited Loading

benjamingr left a comment

Choose a reason for hiding this comment

jasnell commented Sep 26, 2019

ronag commented Sep 26, 2019 • edited Loading

Trott commented Oct 1, 2019

BethGriggs commented Oct 1, 2019

mcollina commented Oct 1, 2019

jasnell commented Oct 1, 2019

Trott commented Oct 1, 2019

mcollina commented Oct 9, 2019

mafintosh commented Oct 9, 2019

Trott commented Oct 9, 2019

Trott left a comment

Choose a reason for hiding this comment

Trott commented Oct 9, 2019

ronag commented Oct 9, 2019

nodejs-github-bot commented Oct 9, 2019 • edited by Trott Loading

This comment has been minimized.

Trott commented Oct 9, 2019 • edited Loading

mcollina commented Oct 10, 2019

mcollina commented Oct 10, 2019

mcollina commented Oct 10, 2019

BethGriggs commented Oct 10, 2019

ronag commented Sep 26, 2019 •

edited

Loading

ronag commented Sep 26, 2019 •

edited

Loading

nodejs-github-bot commented Oct 9, 2019 •

edited by Trott

Loading

Trott commented Oct 9, 2019 •

edited

Loading