-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stream: 'error' should be emitted asynchronously #29742
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
force-pushed
the
fix-async-error
branch
from
September 28, 2019 05:37
cb7b8c6
to
72effb3
Compare
nodejs-github-bot
added
the
stream
Issues and PRs related to the stream subsystem.
label
Sep 28, 2019
errorOrDestroy emits 'error' synchronously due to compat reasons. However, it should be possible to use correct async behaviour for new code.
ronag
force-pushed
the
fix-async-error
branch
from
September 28, 2019 05:37
72effb3
to
4557b48
Compare
2 tasks
ronag
changed the title
Fix async error
stream: 'error' should be emitted asynchronously
Sep 28, 2019
lpinca
approved these changes
Sep 28, 2019
@nodejs/streams |
Added |
Revert landed, but this fix can go into the original PR. |
This was referenced May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
errorOrDestroy
emits'error'
synchronously due to compat reasons. However, it should be possible to use correct async behaviour for new code.Fixes: #29741
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes