test: debug output for dlopen-ping-pong test #29818
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make test failures easier to diagnose through progress logging, and reporting of dlerror().
nodejs-github-bot
added
addons
Trott
approved these changes
Oct 2, 2019
Trott
added
the
author ready
63 tasks
richardlau
approved these changes
Oct 2, 2019
cclauss
reviewed
Oct 2, 2019
cclauss
approved these changes
Oct 2, 2019
cjihrig
approved these changes
Oct 2, 2019
BridgeAR
approved these changes
Oct 3, 2019
bnoordhuis
approved these changes
Oct 3, 2019
| process.dlopen(module, bindingPath, | ||
| os.constants.dlopen.RTLD_NOW | os.constants.dlopen.RTLD_GLOBAL); | ||
| console.log('module.exports.load:', `${path.dirname(bindingPath)}/ping.so`); | ||
| module.exports.load(`${path.dirname(bindingPath)}/ping.so`); |
There was a problem hiding this comment.
Maybe DRY this to const pingPath = ...? Ditto around line 21.
|
Landed in 51c097b |
sam-github
added a commit
that referenced
this pull request
Oct 9, 2019
Make test failures easier to diagnose through progress logging, and reporting of dlerror(). PR-URL: #29818 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
BridgeAR
pushed a commit
that referenced
this pull request
Oct 9, 2019
Make test failures easier to diagnose through progress logging, and reporting of dlerror(). PR-URL: #29818 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make test failures easier to diagnose through progress logging, and
reporting of dlerror().
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes