build: build benchmark addons like test addons #29995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
richardlau
referenced
this pull request
Oct 16, 2019
Since worker threads are complete Node.js environments, including the ability to load native addons, and since those native addons can allocate resources to be freed when objects go out of scope, and since, upon worker thread exit, the engine does not invoke the weak callbacks responsible for freeing resources which still have references, this modification introduces tracking for weak references such that a list of outstanding weak references is maintained. This list is traversed during environment teardown. The callbacks for the remaining weak references are called. This change is also relevant for Node.js embedder scenarios, because in those cases the process also outlives the `node::Environment` and therefore weak callbacks should also be rendered as environment cleanup hooks to ensure proper cleanup after native addons. This changes introduces the means by which this can be accomplished. A benchmark is included which measures the time it takes to execute the weak reference callback for a given number of weak references. Re: tc39/proposal-weakrefs#125 (comment) PR-URL: #28428 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
cc @nodejs/n-api @nodejs/build-files @Trott |
richardlau
added
benchmark
|
Benchmark CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/9538/ (✔️) |
addaleax
approved these changes
Oct 16, 2019
Trott
approved these changes
Oct 16, 2019
richardlau
added
the
author ready
BethGriggs
approved these changes
Oct 16, 2019
|
I propose fast-tracking this to un-break nightly CI. Collaborators, please 👍 here if you agree. Thanks! |
|
Going to step away from my computer for a bit. Still waiting for https://ci.nodejs.org/job/node-test-commit-arm/26747/nodes=debian9-docker-armv7/ to complete (it was queued for four hours waiting for a free |
gengjiawen
approved these changes
Oct 17, 2019
Build the addons for benchmarks in the same way that the addons for tests are built. PR-URL: nodejs#29995 Fixes: nodejs/build#1961 Refs: nodejs@53ca0b9#commitcomment-35494896 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
|
Landed in c8df5cf. |
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Oct 22, 2019
Build the addons for benchmarks in the same way that the addons for tests are built. PR-URL: nodejs#29995 Fixes: nodejs/build#1961 Refs: nodejs@53ca0b9#commitcomment-35494896 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This was referenced Oct 22, 2019
MylesBorins
pushed a commit
that referenced
this pull request
Oct 23, 2019
Build the addons for benchmarks in the same way that the addons for tests are built. PR-URL: #29995 Fixes: nodejs/build#1961 Refs: 53ca0b9#commitcomment-35494896 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 23, 2019
Build the addons for benchmarks in the same way that the addons for tests are built. PR-URL: #29995 Fixes: nodejs/build#1961 Refs: 53ca0b9#commitcomment-35494896 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Nov 8, 2019
Build the addons for benchmarks in the same way that the addons for tests are built. PR-URL: #29995 Fixes: nodejs/build#1961 Refs: 53ca0b9#commitcomment-35494896 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 10, 2019
Build the addons for benchmarks in the same way that the addons for tests are built. PR-URL: #29995 Fixes: nodejs/build#1961 Refs: 53ca0b9#commitcomment-35494896 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build the addons for benchmarks in the same way that the addons for
tests are built.
Fixes: nodejs/build#1961
Refs: 53ca0b9#commitcomment-35494896
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes