n-api: add napi_get_all_property_names #30006

himself65 · 2019-10-17T12:09:32Z

follow up by #28944

support to get all property of an object.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

src/js_native_api.h

src/js_native_api_types.h

doc/api/n-api.md

src/js_native_api_types.h

doc/api/n-api.md

src/js_native_api_v8.cc

doc/api/n-api.md

legendecas · 2019-11-16T09:37:01Z

doc/api/n-api.md

+
+```C
+typedef enum {
+  napi_key_include_all_properties,


Would there be any possible ambiguity on these similar naming of napi_key_include_all_properties and napi_key_all_properties? IIUC the napi_key_collection_mode indicates whether or not the keys on the prototype chains are collected, and napi_key_filter filters property descriptors.

Would it be possible to name napi_key_collection_mode following v8's pattern? i.e. napi_key_include_prototypes, which would sound very precise.

I've changed them to napi_key_include_prototypes and napi_key_include_own_properties to follow v8's pattern, I think

doc/api/n-api.md

+```C
+typedef enum {
+  napi_key_include_all_properties,
+  napi_key_include_own_properties


gabrielschulhof

Will be LGTM once the enums are documented.

src/js_native_api_types.h

macOS package notarization and a change in builder configuration The macOS binaries for this release, and future 10.x releases, are now being compiled on macOS 10.15 (Catalina) with Xcode 11 to support package notarization, a requirement for installing .pkg files on macOS 10.15 and later. Previous builds of Node.js 10.x were compiled on macOS 10.10 (Yosemite) with a minimum deployment target of macOS 10.7 (Lion). As binaries are still being compiled to support a minimum of macOS 10.7 (Lion) we do not anticipate this having a negative impact on Node.js 10.x users with older versions of macOS. Notable changes: - buffer: add {read|write}Big\[U\]Int64{BE|LE} methods (garygsc) [#19691](#19691) - build: macOS package notarization (Rod Vagg) [#31459](#31459) - deps: - update npm to 6.14.3 (Myles Borins) [#32368](#32368) - upgrade openssl sources to 1.1.1e (Hassaan Pasha) [#32328](#32328) - upgrade to libuv 1.34.2 (cjihrig) [#31477](#31477) - n-api: - add napi\_get\_all\_property\_names (himself65) [#30006](#30006) - add APIs for per-instance state management (Gabriel Schulhof) [#28682](#28682) - define release 6 [#32058](#32058) - turn NAPI\_CALL\_INTO\_MODULE into a function (Anna Henningsen) [#26128](#26128) - tls: - expose keylog event on TLSSocket (Alba Mendez) [#27654](#27654) - support TLS min/max protocol defaults in CLI (Sam Roberts) [#27946](#27946) - url: handle quasi-WHATWG URLs in urlToOptions() (cjihrig) [#26226](#26226) PR-URL: #31984

Co-Authored-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Backport-PR-URL: nodejs#32482 PR-URL: nodejs#30006 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Co-Authored-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Backport-PR-URL: #32482 PR-URL: #30006 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Even though the redefinition complies with the C standard because the second definition is "effectively the same" as the first definition, it's best to avoid any redefinition. Refs: nodejs#28237 Refs: nodejs#30006

Even though the redefinition complies with the C standard because the second definition is "effectively the same" as the first definition, it's best to avoid any redefinition. Refs: #28237 Refs: #30006 PR-URL: #48879 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Even though the redefinition complies with the C standard because the second definition is "effectively the same" as the first definition, it's best to avoid any redefinition. Refs: nodejs#28237 Refs: nodejs#30006 PR-URL: nodejs#48879 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Even though the redefinition complies with the C standard because the second definition is "effectively the same" as the first definition, it's best to avoid any redefinition. Refs: #28237 Refs: #30006 PR-URL: #48879 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Even though the redefinition complies with the C standard because the second definition is "effectively the same" as the first definition, it's best to avoid any redefinition. Refs: nodejs/node#28237 Refs: nodejs/node#30006 PR-URL: nodejs/node#48879 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 17, 2019

himself65 force-pushed the 2 branch 4 times, most recently from a1b77a7 to af01359 Compare October 17, 2019 14:43

himself65 marked this pull request as ready for review October 17, 2019 14:58

mhdawson reviewed Oct 17, 2019

View reviewed changes

src/js_native_api.h Outdated Show resolved Hide resolved

himself65 force-pushed the 2 branch from af01359 to daedbe9 Compare October 18, 2019 02:55

legendecas reviewed Oct 18, 2019

View reviewed changes

src/js_native_api_types.h Show resolved Hide resolved

himself65 force-pushed the 2 branch 2 times, most recently from b75445e to e7f6866 Compare October 18, 2019 17:22

legendecas reviewed Oct 19, 2019

View reviewed changes

doc/api/n-api.md Outdated Show resolved Hide resolved

src/js_native_api_types.h Show resolved Hide resolved

src/js_native_api_types.h Outdated Show resolved Hide resolved

himself65 force-pushed the 2 branch from e7f6866 to aa6cc8f Compare October 20, 2019 07:23

gabrielschulhof reviewed Oct 24, 2019

View reviewed changes

doc/api/n-api.md Outdated Show resolved Hide resolved

doc/api/n-api.md Outdated Show resolved Hide resolved

src/js_native_api_v8.cc Outdated Show resolved Hide resolved

gabrielschulhof added the node-api Issues and PRs related to the Node-API. label Oct 24, 2019

himself65 force-pushed the 2 branch from e732408 to d478cd1 Compare October 28, 2019 11:39

gabrielschulhof reviewed Nov 15, 2019

View reviewed changes

himself65 force-pushed the 2 branch 5 times, most recently from 475eddf to 8e21c82 Compare November 16, 2019 09:24

legendecas reviewed Nov 16, 2019

View reviewed changes

himself65 force-pushed the 2 branch from 8e21c82 to 52c869a Compare November 16, 2019 10:37

legendecas mentioned this pull request Nov 17, 2019

n-api: add napi_get_own_property_names #28944

Closed

4 tasks

himself65 force-pushed the 2 branch 3 times, most recently from e39c1b9 to 3fcc0c9 Compare November 18, 2019 16:02

gabrielschulhof reviewed Nov 23, 2019

View reviewed changes

src/js_native_api_types.h Show resolved Hide resolved

himself65 force-pushed the 2 branch from 3fcc0c9 to e759181 Compare November 23, 2019 04:14

goto-bus-stop mentioned this pull request Apr 10, 2020

Plain data objects neon-bindings/neon#493

Merged

targos removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lts-watch-v12.x labels Apr 25, 2020

targos added the backported-to-v12.x label Apr 25, 2020

targos mentioned this pull request May 2, 2020

v12.17.0 release proposal #33197

Merged

tniessen mentioned this pull request Jul 21, 2023

node-api: avoid macro redefinition #48879

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

n-api: add napi_get_all_property_names #30006

n-api: add napi_get_all_property_names #30006

himself65 commented Oct 17, 2019 •

edited

Loading

legendecas Nov 16, 2019

himself65 Nov 17, 2019

This comment was marked as outdated.

gabrielschulhof left a comment

n-api: add napi_get_all_property_names #30006

n-api: add napi_get_all_property_names #30006

Conversation

himself65 commented Oct 17, 2019 • edited Loading

Checklist

legendecas Nov 16, 2019

Choose a reason for hiding this comment

himself65 Nov 17, 2019

Choose a reason for hiding this comment

This comment was marked as outdated.

gabrielschulhof left a comment

Choose a reason for hiding this comment

himself65 commented Oct 17, 2019 •

edited

Loading