Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

child_process: create proper public API for channel #30165

Closed

Commits on Jan 3, 2020

  1. child_process: create proper public API for channel

    Instead of exposing the C++ bindings object as `subprocess.channel`
    or `process.channel`, provide the “control” object that was
    previously used internally as the public-facing variant of it.
    
    This should be better than returning the raw pipe object, and
    matches the original intention (when the `channel` property was
    first added) of providing a proper way to `.ref()` or `.unref()`
    the channel.
    
    Refs: nodejs#9322
    Refs: nodejs#9313
    addaleax committed Jan 3, 2020
    Configuration menu
    Copy the full SHA
    ef418e1 View commit details
    Browse the repository at this point in the history