-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: clarify IncomingMessage.destroy() description #30255
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
State that the 'error' event is emitted on the underlying socket, not the IncomingMessage object.
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
http
Issues or PRs related to the http subsystem.
labels
Nov 4, 2019
jasnell
approved these changes
Nov 5, 2019
lundibundi
approved these changes
Nov 23, 2019
lundibundi
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Nov 23, 2019
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
State that the 'error' event is emitted on the underlying socket, not the IncomingMessage object. PR-URL: #30255 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Landed in c8930fb, thanks for the PR and sorry for the delay! |
addaleax
pushed a commit
that referenced
this pull request
Nov 30, 2019
State that the 'error' event is emitted on the underlying socket, not the IncomingMessage object. PR-URL: #30255 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 5, 2019
State that the 'error' event is emitted on the underlying socket, not the IncomingMessage object. PR-URL: #30255 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
State that the 'error' event is emitted on the underlying socket, not the IncomingMessage object. PR-URL: #30255 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
http
Issues or PRs related to the http subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
State that the 'error' event is emitted on the underlying socket, not
the IncomingMessage object.
Here are the relevant parts in the code:
Here's a program that demonstrates this
Then,
curl localhost:8080
The Node.js process doesn't print the error
Checklist