Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update GOVERNANCE.md #30259

Merged
merged 0 commits into from
Nov 7, 2019
Merged

doc: update GOVERNANCE.md #30259

merged 0 commits into from
Nov 7, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 5, 2019

This consists of some hopefully-uncontroversial
simplifications/clarifications to the text. The one substantial change
is to update Node.js Board of Directors to be the OpenJS Board of
Directors.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 5, 2019
@Trott
Copy link
Member Author

Trott commented Nov 5, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4030/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 5, 2019
mhdawson
mhdawson approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member Author

Trott commented Nov 7, 2019

Landed in 35ae49d

@Trott Trott closed this Nov 7, 2019
@Trott Trott merged commit 35ae49d into nodejs:master Nov 7, 2019
MylesBorins pushed a commit that referenced this pull request Nov 17, 2019
@Trott @MylesBorins
doc: update GOVERNANCE.md
31a3b72 
This consists of some hopefully-uncontroversial
simplifications/clarifications to the text. The one substantial change
is to update Node.js Board of Directors to be the OpenJS Board of
Directors.

PR-URL: #30259
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
Merged
targos pushed a commit that referenced this pull request Dec 1, 2019
@Trott @targos
doc: update GOVERNANCE.md
cf89100 
This consists of some hopefully-uncontroversial
simplifications/clarifications to the text. The one substantial change
is to update Node.js Board of Directors to be the OpenJS Board of
Directors.

PR-URL: #30259
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@Trott @MylesBorins
doc: update GOVERNANCE.md
d713e5a 
This consists of some hopefully-uncontroversial
simplifications/clarifications to the text. The one substantial change
is to update Node.js Board of Directors to be the OpenJS Board of
Directors.

PR-URL: #30259
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
@Trott Trott deleted the copyedit-gov-doc branch January 20, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@mhdawson mhdawson mhdawson approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cclauss cclauss cclauss approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Trott @lpinca @targos @cjihrig @cclauss @gireeshpunathil @BridgeAR @mhdawson @trivikr @nodejs-github-bot