Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v10.x backport] lib: fix comment nits in bootstrap\loaders.js #30338

Closed
wants to merge 1 commit into from
Closed

[v10.x backport] lib: fix comment nits in bootstrap\loaders.js #30338

wants to merge 1 commit into from

Conversation

GaryGSC
Copy link
Contributor

@GaryGSC GaryGSC commented Nov 8, 2019

PR-URL: #24641
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Franziska Hinkelmann franziska.hinkelmann@gmail.com

(cherry picked from commit 1db808c)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@vsemozhetbyt @GaryGSC
lib: fix comment nits in bootstrap\loaders.js
e37212f 
Backport-PR-URL: nodejs#30338

PR-URL: nodejs#24641
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

(cherry picked from commit 1db808c)
@GaryGSC
Copy link
Contributor Author

GaryGSC commented Nov 8, 2019

It appears I don't have permission to run a node-test-pull-request CI job, as requested by the backporting guide.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26480/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26755/

@BethGriggs
Copy link
Member

CI ✅ (known failures from #29977)

BethGriggs pushed a commit that referenced this pull request Nov 22, 2019
@vsemozhetbyt @BethGriggs
lib: fix comment nits in bootstrap\loaders.js
efeac48 
Backport-PR-URL: #30338
PR-URL: #24641
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@BethGriggs
Copy link
Member

Landed on v10.x-staging
Thank you for the backport

@BethGriggs BethGriggs closed this Nov 22, 2019
@GaryGSC GaryGSC deleted the backport-24641-to-v10.x branch November 22, 2019 20:14
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@vsemozhetbyt @MylesBorins
lib: fix comment nits in bootstrap\loaders.js
81c3100 
Backport-PR-URL: #30338
PR-URL: #24641
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

@devnexen devnexen devnexen approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GaryGSC @nodejs-github-bot @BethGriggs @addaleax @devnexen @vsemozhetbyt