-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: update tzdata to 2019c #30356
Conversation
@srl295 @MylesBorins @nodejs/intl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I would like us to fastrack this |
note also #29540 |
This needs one more approval before it can land. @MylesBorins ? |
So this could be a periodic chore. Related: I don't think we want to go down the route where |
That depends on how often timezone data changes and whether we want to enable a pathway where users can apply timezone fixes without having to update Node.js (thinking more of the LTS lines here where releases are more spread out, unless we need to class timezone updates as more urgent requiring out-of-schedule releases). cc @nodejs/lts |
tzdata changes pretty often. For example, 2018 saw 9 tzdata updates. 2019 so far has had 3. For node to stay up to date, a diff like this should happen every few months. (it just so happens that most changes are relatively minor, like for Fiji or North Korea; the current push is because a much larger country Brazil decided to change its time zone policy). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber stamp
Landed in 31ea341 |
@MylesBorins @srl295 If we want to land it on v12.x, we need a backport PR because the data file is different there (not compressed, small-icu). |
Refs: nodejs#30211 Refs: nodejs#30356
Refs: nodejs#30211 Refs: nodejs#30356
Update the version of the bundled ICU (deps/icu-small) to ICU version 65.2. Fixes: nodejs#30211 Fixes: nodejs#29540 Backport-PR-URL: nodejs#31434 PR-URL: nodejs#30356 PR-URL: nodejs#30232
Based on the instructions in #30211 (comment), I updated the time zone database separately from the rest of the ICU data. This should be a cut-down version of #30232 .
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passestests and/or benchmarks are includeddocumentation is changed or added