Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/timers.js: replace var with let/const #30404

Closed
wants to merge 1 commit into from
Closed

lib/timers.js: replace var with let/const #30404

wants to merge 1 commit into from

Conversation

TimEmbrechts
Copy link

@TimEmbrechts TimEmbrechts commented Nov 12, 2019 •
edited by BridgeAR
Loading

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows

@nodejs-github-bot nodejs-github-bot added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Nov 12, 2019
@jasnell jasnell added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 12, 2019
trivikr
trivikr approved these changes Nov 13, 2019
View reviewed changes
lib/timers.js
@@ -118,7 +118,7 @@ function setTimeout(callback, after, arg1, arg2, arg3) {
throw new ERR_INVALID_CALLBACK(callback);
}

var i, args;
let i, args;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: move i to line 135?

for (let i = 5; i < arguments.length; i++) {

lib/timers.js
@@ -164,7 +164,7 @@ function setInterval(callback, repeat, arg1, arg2, arg3) {
throw new ERR_INVALID_CALLBACK(callback);
}

var i, args;
let i, args;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: move i to line 181?

for (let i = 5; i < arguments.length; i++) {

lib/timers.js
@@ -248,7 +248,7 @@ function setImmediate(callback, arg1, arg2, arg3) {
throw new ERR_INVALID_CALLBACK(callback);
}

var i, args;
let i, args;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: move i to line 264?

for (let i = 4; i < arguments.length; i++) {

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26683/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26900/

gireeshpunathil pushed a commit that referenced this pull request Nov 24, 2019
@gireeshpunathil
lib: replace var with let/const
ee81bce 
PR-URL: #30404
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@gireeshpunathil
Copy link
Member

landed in ee81bce, thanks for the contribution!

addaleax pushed a commit that referenced this pull request Nov 30, 2019
@addaleax
lib: replace var with let/const
48fef42 
PR-URL: #30404
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Dec 1, 2019
@targos
lib: replace var with let/const
17db4e3 
PR-URL: #30404
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
Merged
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@MylesBorins
lib: replace var with let/const
0c4bb4a 
PR-URL: #30404
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@TimEmbrechts @nodejs-github-bot @gireeshpunathil @jasnell @BridgeAR @trivikr