Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: use let instead of var in assert #30451

Closed
wants to merge 1 commit into from
Closed

benchmark: use let instead of var in assert #30451

wants to merge 1 commit into from

Conversation

dnlup
Copy link
Contributor

@dnlup dnlup commented Nov 12, 2019

Use let instead of var in benchmark/assert/deepequal-map.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@dnlup
benchmark: use let instead of var in assert
6aead5c 
Use let instead of var in benchmark/assert/deepequal-map.js.
@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. benchmark Issues and PRs related to the benchmark subsystem. labels Nov 12, 2019
devnexen
devnexen approved these changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice but could have been done in one PR eventually with the previous.

@dnlup
Copy link
Contributor Author

dnlup commented Nov 12, 2019 •
edited
Loading

@devnexen Makes sense, should I finish all the remaining files in assert here or in the first PR Sorry, I'll put everything in the previous PR.

@dnlup
Copy link
Contributor Author

dnlup commented Nov 12, 2019

Closing in favour of #30450

@dnlup dnlup closed this Nov 12, 2019
@dnlup dnlup deleted the fix_benchmark_assert_deepequal_map branch January 10, 2020 13:39
@snyk-bot snyk-bot mentioned this pull request Jun 1, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. benchmark Issues and PRs related to the benchmark subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnlup @devnexen @nodejs-github-bot