Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update http parser 2.9.1 v8.x #30472

Closed
wants to merge 2 commits into from
Closed

Update http parser 2.9.1 v8.x #30472

wants to merge 2 commits into from

Conversation

sam-github
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

sam-github and others added 2 commits November 13, 2019 10:18
@sam-github
deps: upgrade http-parser to v2.9.1
ea92ad8
@mcollina @sam-github
deps,http: http_parser set max header size to 8KB
722cc86 
Reapplying HTTP_MAX_HEADER_SIZE=8192 to http_parser.gyp.

CVE-2018-12121

PR-URL: https://github.com/nodejs-private/node-private/pull/143
Ref: https://github.com/nodejs-private/security/issues/139
Ref: https://github.com/nodejs-private/http-parser-private/pull/2
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@nodejs-github-bot nodejs-github-bot added http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding. v8.x labels Nov 13, 2019
@sam-github sam-github mentioned this pull request Nov 13, 2019
Closed
4 tasks
@BridgeAR
Copy link
Member

BridgeAR commented Jan 2, 2020

I am closing this since there won't be any further v8.x releases. Too bad this could not make it!

@BridgeAR BridgeAR closed this Jan 2, 2020
@sam-github sam-github deleted the update-http_parser-2.9.1-v8.x branch January 7, 2020 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes

Assignees
No one assigned
Labels
http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sam-github @BridgeAR @gengjiawen @nodejs-github-bot @mcollina