Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module: fix specifier resolution algorithm #30574

Closed
wants to merge 1 commit into from
Closed

module: fix specifier resolution algorithm #30574

wants to merge 1 commit into from

Conversation

pd4d10
Copy link
Contributor

@pd4d10 pd4d10 commented Nov 21, 2019

Fixes: #30520

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@pd4d10 pd4d10 mentioned this pull request Nov 21, 2019
Closed
@cjihrig
Copy link
Contributor

cjihrig commented Nov 21, 2019

Can you add tests?

@pd4d10
Copy link
Contributor Author

pd4d10 commented Nov 21, 2019

@cjihrig OK, I'll try to add some tests for this case.

@guybedford
Copy link
Contributor

I know I suggested this approach as a simple way to resolve the issue, but I don't think we should support .mjs searching in the CommonJS resolver, even under this flag.

The alternative would be to use the ESM resolver when this flag is set. That can be achieved by having the shouldUseESMLoader function in https://github.com/nodejs/node/blob/master/lib/internal/modules/run_main.js#L23 return true whenever this flag is set.

@guybedford
Copy link
Contributor

And yes, tests very much necessary too.

@pd4d10
Copy link
Contributor Author

pd4d10 commented Nov 22, 2019

Hi @guybedford, I've updated the implementation and tests for this case.

guybedford
guybedford approved these changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you @pd4d10 for taking a look at this.

lib/internal/modules/run_main.js
@@ -24,6 +24,10 @@ function shouldUseESMLoader(mainPath) {
const userLoader = getOptionValue('--experimental-loader');
if (userLoader)
return true;
const esModuleSpecifierResolution =
getOptionValue('--es-module-specifier-resolution');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. One thing to note is that this flag is experimental. I just posted an issue about this here - #30600.

Since this is now the primary entry for this flag, we should probably move this check up to the top of the function, and also include a warning like:

process.emitWarning(
    'The --es-module-specifier-resolution flag is experimental.',
    'ExperimentalWarning', undefined);

Would help to add this stuff while we're working on this area anyway, but if you'd rather it be done separately that is fine too just thought I'd mention as it's important for users not to overlook that any of these flags might be removed in future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation. I've noticed that #30600 is not only about specifier-resolution but also related to other experimental flags, so perhaps the fix about it should be raised in another PR rather than merged to this one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I don't understand it wrong, I'll try to work on #30600 and create another PR to fix it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure if you're able to work on that it would be great, just mentioning as otherwise it can be useful to do these things while we're there.

MylesBorins
MylesBorins approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27067/

@MylesBorins MylesBorins added the esm Issues and PRs related to the ECMAScript Modules implementation. label Nov 27, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27070/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 27, 2019 •
edited by MylesBorins
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/27113/

rerun windows: https://ci.nodejs.org/job/node-test-commit-windows-fanned/31766/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27142/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 28, 2019
@Trott
Copy link
Member

Trott commented Nov 28, 2019

Landed in f5ef7cd

@Trott Trott closed this Nov 28, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 28, 2019
@pd4d10 @Trott
module: fix specifier resolution algorithm
f5ef7cd 
Fixes: nodejs#30520

PR-URL: nodejs#30574
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@pd4d10 pd4d10 deleted the patch-1 branch November 29, 2019 02:43
addaleax pushed a commit that referenced this pull request Nov 30, 2019
@pd4d10 @addaleax
module: fix specifier resolution algorithm
2cf8a7f 
Fixes: #30520

PR-URL: #30574
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
Merged
MylesBorins pushed a commit that referenced this pull request Jan 12, 2020
@pd4d10 @MylesBorins
module: fix specifier resolution algorithm
9696e9e 
Fixes: #30520

PR-URL: #30574
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@pd4d10 @BethGriggs
module: fix specifier resolution algorithm
d65566a 
Fixes: #30520

PR-URL: #30574
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guybedford guybedford guybedford approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. esm Issues and PRs related to the ECMAScript Modules implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--es-module-specifier-resolution=node not working from v13.0.1
6 participants
@pd4d10 @cjihrig @guybedford @nodejs-github-bot @Trott @MylesBorins