Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add note about debugging worker_threads #30594

Closed
wants to merge 1 commit into from
Closed

doc: add note about debugging worker_threads #30594

wants to merge 1 commit into from

Conversation

lundibundi
Copy link
Member

Closes: #30197

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

/cc @nodejs/documentation

@nodejs-github-bot nodejs-github-bot added debugger doc Issues and PRs related to the documentations. labels Nov 22, 2019
@lundibundi
Copy link
Member Author

LiteCI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4084/

@addaleax addaleax added the worker Issues and PRs related to Worker support. label Nov 22, 2019
@lundibundi lundibundi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 22, 2019
danbev pushed a commit that referenced this pull request Nov 25, 2019
@lundibundi @danbev
doc: add note about debugging worker_threads
84a95b8 
PR-URL: #30594
Fixes: #30197
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@danbev
Copy link
Contributor

danbev commented Nov 25, 2019

Landed in 84a95b8.

@danbev danbev closed this Nov 25, 2019
addaleax pushed a commit that referenced this pull request Nov 30, 2019
@lundibundi @addaleax
doc: add note about debugging worker_threads
7d98a59 
PR-URL: #30594
Fixes: #30197
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit that referenced this pull request Dec 1, 2019
@lundibundi @targos
doc: add note about debugging worker_threads
77cbf09 
PR-URL: #30594
Fixes: #30197
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BridgeAR BridgeAR mentioned this pull request Dec 3, 2019
Merged
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@lundibundi @MylesBorins
doc: add note about debugging worker_threads
7ebafda 
PR-URL: #30594
Fixes: #30197
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is it possible to debug nodejs server with workers?
7 participants
@lundibundi @danbev @addaleax @lpinca @gireeshpunathil @trivikr @nodejs-github-bot