-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: document "Resume Build" limitation #30604
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for my understanding, if, say, only AIX failed, then this would not matter (even though it may be a good idea to start a fresh CI anyway)?
Yes, that's correct. I tried to keep the doc changes brief and simple. It is probably a good idea to start a new CI after seven days anyway to pick up changes in the branch being merged into. |
Compiled binaries for fanned CI builds on Windows and ARM are only kept for seven days. PR-URL: nodejs#30604 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
bc1d94c
to
f3a5097
Compare
Landed in f3a5097. |
Compiled binaries for fanned CI builds on Windows and ARM are only kept for seven days. PR-URL: #30604 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Compiled binaries for fanned CI builds on Windows and ARM are only kept for seven days. PR-URL: #30604 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Compiled binaries for fanned CI builds on Windows and ARM are only kept for seven days. PR-URL: #30604 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Compiled binaries for fanned CI builds on Windows and ARM are only kept
for seven days. Document that a fresh CI should be started if more than
seven days have elapsed since the original failing CI.
Refs: nodejs/build#1515 (comment)
cc @BethGriggs
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes