build: add --without-node-code-cache configure option #30647

joyeecheung · 2019-11-26T05:05:55Z

build: add --without-node-code-cache configure option

So that it's possible to build without code cache (in particular,
without building mkcodecache) for testing.

build: do not build mksnapshot and mkcodecache for --shared

To build mkcodecache and mksnapshot (they are executables),
we currently build libnode with unresolved symbols, then build
the two exectuables with src/node_snapshot_stub.cc and
src/node_code_cache_stub.cc. Each of them write a C++ file to
disk when being run. We then use the generated C++ files & libnode
(with unresolved symbols) to build the final Node executable.

However, if libnode itself is the final product, then we should
not build it with unresolved symbols.
#28897 added the two stubs
for the libnode target when the --shared configure option is used,
but it did not get rid of the actions to build and run mksnapshot
and mkcodecache for --shared, so to get it working we also
need a patch to make sure --shared imply --without-node-code-cache
and --without-node-snapshot, until we actually fix the TODO so that
mksnapshot and mkcodecache do not use the libnode that way.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2019-11-26T05:06:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/26999/

So that it's possible to build without code cache (in particular, without building mkcodecache) for testing.

To build mkcodecache and mksnapshot (they are executables), we currently build libnode with unresolved symbols, then build the two exectuables with src/node_snapshot_stub.cc and src/node_code_cache_stub.cc. Each of them write a C++ file to disk when being run. We then use the generated C++ files & libnode (with unresolved symbols) to build the final Node executable. However, if libnode itself is the final product, then we should not build it with unresolved symbols. nodejs#28897 added the two stubs for the libnode target when the --shared configure option is used, but it did not get rid of the actions to build and run mksnapshot and mkcodecache for --shared, so I think to get it working we also need a patch to make sure --shared imply --without-node-code-cache and --without-node-snapshot, until we actually fix the TODO so that mksnapshot and mkcodecache do not use the libnode that way.

joyeecheung · 2019-11-26T05:39:32Z

Added another commit to make sure --shared imply --without-node-code-cache and --without-node-snapshot, and fixed the test.

nodejs-github-bot · 2019-11-26T05:40:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27005/

davidhouweling · 2019-11-26T09:00:33Z

I believe the vcbuild.bat needs to be updated to reflect the new flag. Refer to #28845 (comment) for more info.

bnoordhuis

LGTM % style nits.

configure.py

addaleax

Looks good!

joyeecheung · 2019-11-26T15:58:05Z

I believe the vcbuild.bat needs to be updated to reflect the new flag. Refer to #28845 (comment) for more info.

vcbuild.bat dll uses --shared which should just imply the new flag with this PR?

nodejs-github-bot · 2019-12-02T13:47:55Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27268/

So that it's possible to build without code cache (in particular, without building mkcodecache) for testing. PR-URL: #30647 Refs: #28845 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

To build mkcodecache and mksnapshot (they are executables), we currently build libnode with unresolved symbols, then build the two exectuables with src/node_snapshot_stub.cc and src/node_code_cache_stub.cc. Each of them write a C++ file to disk when being run. We then use the generated C++ files & libnode (with unresolved symbols) to build the final Node executable. However, if libnode itself is the final product, then we should not build it with unresolved symbols. #28897 added the two stubs for the libnode target when the --shared configure option is used, but it did not get rid of the actions to build and run mksnapshot and mkcodecache for --shared, so to get it working we also need a patch to make sure --shared imply --without-node-code-cache and --without-node-snapshot, until we actually fix the TODO so that mksnapshot and mkcodecache do not use the libnode that way. PR-URL: #30647 Refs: #28845 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

joyeecheung · 2019-12-03T09:31:26Z

Landed in cc3f2b3...8cf8eb1

So that it's possible to build without code cache (in particular, without building mkcodecache) for testing. PR-URL: #30647 Refs: #28845 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

To build mkcodecache and mksnapshot (they are executables), we currently build libnode with unresolved symbols, then build the two exectuables with src/node_snapshot_stub.cc and src/node_code_cache_stub.cc. Each of them write a C++ file to disk when being run. We then use the generated C++ files & libnode (with unresolved symbols) to build the final Node executable. However, if libnode itself is the final product, then we should not build it with unresolved symbols. #28897 added the two stubs for the libnode target when the --shared configure option is used, but it did not get rid of the actions to build and run mksnapshot and mkcodecache for --shared, so to get it working we also need a patch to make sure --shared imply --without-node-code-cache and --without-node-snapshot, until we actually fix the TODO so that mksnapshot and mkcodecache do not use the libnode that way. PR-URL: #30647 Refs: #28845 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

So that it's possible to build without code cache (in particular, without building mkcodecache) for testing. PR-URL: #30647 Refs: #28845 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

To build mkcodecache and mksnapshot (they are executables), we currently build libnode with unresolved symbols, then build the two exectuables with src/node_snapshot_stub.cc and src/node_code_cache_stub.cc. Each of them write a C++ file to disk when being run. We then use the generated C++ files & libnode (with unresolved symbols) to build the final Node executable. However, if libnode itself is the final product, then we should not build it with unresolved symbols. #28897 added the two stubs for the libnode target when the --shared configure option is used, but it did not get rid of the actions to build and run mksnapshot and mkcodecache for --shared, so to get it working we also need a patch to make sure --shared imply --without-node-code-cache and --without-node-snapshot, until we actually fix the TODO so that mksnapshot and mkcodecache do not use the libnode that way. PR-URL: #30647 Refs: #28845 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

So that it's possible to build without code cache (in particular, without building mkcodecache) for testing. PR-URL: #30647 Refs: #28845 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

To build mkcodecache and mksnapshot (they are executables), we currently build libnode with unresolved symbols, then build the two exectuables with src/node_snapshot_stub.cc and src/node_code_cache_stub.cc. Each of them write a C++ file to disk when being run. We then use the generated C++ files & libnode (with unresolved symbols) to build the final Node executable. However, if libnode itself is the final product, then we should not build it with unresolved symbols. #28897 added the two stubs for the libnode target when the --shared configure option is used, but it did not get rid of the actions to build and run mksnapshot and mkcodecache for --shared, so to get it working we also need a patch to make sure --shared imply --without-node-code-cache and --without-node-snapshot, until we actually fix the TODO so that mksnapshot and mkcodecache do not use the libnode that way. PR-URL: #30647 Refs: #28845 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Nov 26, 2019

joyeecheung added 2 commits November 26, 2019 13:36

build: add --without-node-code-cache configure option

f593a94

So that it's possible to build without code cache (in particular, without building mkcodecache) for testing.

joyeecheung force-pushed the code-cache branch from b079938 to 609fc75 Compare November 26, 2019 05:37

joyeecheung mentioned this pull request Nov 26, 2019

Cannot build static dll on windows v12.7.0 #28845

Closed

bnoordhuis approved these changes Nov 26, 2019

View reviewed changes

configure.py Outdated Show resolved Hide resolved

addaleax approved these changes Nov 26, 2019

View reviewed changes

davidhouweling mentioned this pull request Nov 28, 2019

build: fix static dll compilation on Windows #30695

Closed

4 tasks

devnexen approved these changes Nov 28, 2019

View reviewed changes

fixup! build: do not build mksnapshot and mkcodecache for --shared

3615173

jasnell approved these changes Dec 2, 2019

View reviewed changes

joyeecheung closed this Dec 3, 2019

BridgeAR mentioned this pull request Dec 3, 2019

v13.3.0 proposal #30774

Merged

joyeecheung mentioned this pull request Dec 5, 2019

Windows CI machine updates nodejs/build#1996

Closed

joyeecheung mentioned this pull request Dec 23, 2019

Remove circular dependency in code cache and snapshot building #31074

Closed

targos mentioned this pull request Jan 15, 2020

v12.15.0 release proposal #31368

Closed

MylesBorins mentioned this pull request Feb 8, 2020

v12.16.0 proposal #31691

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: add --without-node-code-cache configure option #30647

build: add --without-node-code-cache configure option #30647

joyeecheung commented Nov 26, 2019 •

edited

Loading

nodejs-github-bot commented Nov 26, 2019

joyeecheung commented Nov 26, 2019

nodejs-github-bot commented Nov 26, 2019

davidhouweling commented Nov 26, 2019 •

edited

Loading

bnoordhuis left a comment

addaleax left a comment

joyeecheung commented Nov 26, 2019 •

edited

Loading

nodejs-github-bot commented Dec 2, 2019

joyeecheung commented Dec 3, 2019

build: add --without-node-code-cache configure option #30647

build: add --without-node-code-cache configure option #30647

Conversation

joyeecheung commented Nov 26, 2019 • edited Loading

Checklist

nodejs-github-bot commented Nov 26, 2019

joyeecheung commented Nov 26, 2019

nodejs-github-bot commented Nov 26, 2019

davidhouweling commented Nov 26, 2019 • edited Loading

bnoordhuis left a comment

Choose a reason for hiding this comment

addaleax left a comment

Choose a reason for hiding this comment

joyeecheung commented Nov 26, 2019 • edited Loading

nodejs-github-bot commented Dec 2, 2019

joyeecheung commented Dec 3, 2019

joyeecheung commented Nov 26, 2019 •

edited

Loading

davidhouweling commented Nov 26, 2019 •

edited

Loading

joyeecheung commented Nov 26, 2019 •

edited

Loading